My FeedDiscussionsHeadless CMS
New
Sign in
Log inSign up
Learn more about Hashnode Headless CMSHashnode Headless CMS
Collaborate seamlessly with Hashnode Headless CMS for Enterprise.
Upgrade ✨Learn more

How should I handle the following disagreement in a code review?

Arthur Brown's photo
Arthur Brown
·Jun 21, 2018

I am working for a fintech startup where we are heavy on unit tests. For a particular release, I spent an entire day writing various unit tests (over 100). My colleague, who is peer-reviewing my code, has suggested that I should write some more tests for some cases that are extremely unlikely to happen. You can say it's extremely rare for those cases to occur. The current test suite covers 99% of the commonly-occurring scenarios.

I admire my co-worker, but I don't agree with this particular approach. What do you think? Should I spend time writing more unit tests for cases that are extremely unlikely to happen? This will delay the release for another day.